Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.3.0 Deployment for Ink Mainnet #922

Merged
merged 2 commits into from
Dec 12, 2024
Merged

v1.3.0 Deployment for Ink Mainnet #922

merged 2 commits into from
Dec 12, 2024

Conversation

akshay-ap
Copy link
Member

Add new chain

Please fill the following form:

Provide the Chain ID (Only 1 chain id per PR).

  • Chain_ID: 57073

@akshay-ap akshay-ap self-assigned this Dec 11, 2024
@akshay-ap akshay-ap requested review from gjeanmart and a team as code owners December 11, 2024 22:05
@nlordell
Copy link
Collaborator

nlordell commented Dec 12, 2024

When trying to verify the deployment, I'm getting:

chain 57073 exists on Chainlist
RPC reported chain 57073
CompatibilityFallbackHandler deployments:
• canonical deployment OK
CreateCall deployments:
• canonical deployment OK
GnosisSafe deployments:
• canonical deployment OK
GnosisSafeL2 deployments:
• canonical deployment OK
MultiSend deployments:
• canonical deployment OK
MultiSendCallOnly deployments:
• canonical deployment OK
GnosisSafeProxyFactory deployments:
• canonical deployment OK
SignMessageLib deployments:
ERROR: SignMessageLib not deployed at 0xA65387F16B013cf2Af4605Ad8aA5ec25a2cbA3a2

@akshay-ap
Copy link
Member Author

When trying to verify the deployment, I'm getting:

chain 57073 exists on Chainlist
RPC reported chain 57073
CompatibilityFallbackHandler deployments:
• canonical deployment OK
CreateCall deployments:
• canonical deployment OK
GnosisSafe deployments:
• canonical deployment OK
GnosisSafeL2 deployments:
• canonical deployment OK
MultiSend deployments:
• canonical deployment OK
MultiSendCallOnly deployments:
• canonical deployment OK
GnosisSafeProxyFactory deployments:
• canonical deployment OK
SignMessageLib deployments:
ERROR: SignMessageLib not deployed at 0xA65387F16B013cf2Af4605Ad8aA5ec25a2cbA3a2

Thanks for reporting. I was using branch v1.3.0 which is missing SignMessageLib deployment.
I used v1.3.0-1 branch now and contracts are now deployed. Also, changed deployments to eip155 addresses.

Verification status for CompatibilityFallbackHandler: SUCCESS
Verification status for CreateCall: SUCCESS
Verification status for DefaultCallbackHandler: SUCCESS
Verification status for GnosisSafe: SUCCESS
Verification status for GnosisSafeL2: SUCCESS
Verification status for GnosisSafeProxyFactory: SUCCESS
Verification status for MultiSend: SUCCESS
Verification status for MultiSendCallOnly: SUCCESS
Verification status for SignMessageLib: SUCCESS
Verification status for SimulateTxAccessor: SUCCESS
✨  Done in 3.50s.

@nlordell
Copy link
Collaborator

Looks good now!

Verified with:

$ npm run -s review:verify-deployment -- --version v1.3.0 --chainId 57073 --rpc $RPC --verbose
Parsed options:
{
  version: 'v1.3.0',
  chainId: '57073',
  rpc: '...',
  verbose: true
}
chain 57073 exists on Chainlist
RPC reported chain 57073
CompatibilityFallbackHandler deployments:
• eip155 deployment OK
CreateCall deployments:
• eip155 deployment OK
GnosisSafe deployments:
• eip155 deployment OK
GnosisSafeL2 deployments:
• eip155 deployment OK
MultiSend deployments:
• eip155 deployment OK
MultiSendCallOnly deployments:
• eip155 deployment OK
GnosisSafeProxyFactory deployments:
• eip155 deployment OK
SignMessageLib deployments:
• eip155 deployment OK
SimulateTxAccessor deployments:
• eip155 deployment OK

@nlordell nlordell merged commit f6f1895 into main Dec 12, 2024
1 of 2 checks passed
@nlordell nlordell deleted the 57073-deployment branch December 12, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants