Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add name property to Accounts #1900

Closed
wants to merge 6 commits into from
Closed

Add name property to Accounts #1900

wants to merge 6 commits into from

Conversation

hectorgomezv
Copy link
Member

Summary

Changes

@hectorgomezv hectorgomezv self-assigned this Sep 5, 2024
@hectorgomezv hectorgomezv linked an issue Sep 5, 2024 that may be closed by this pull request
[User Accounts] Add name to account #1898
Open
@coveralls
Copy link

coveralls commented Sep 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10728428255

Details

  • 6 of 17 (35.29%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.004%) to 45.885%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/domain/accounts/accounts.repository.ts 0 1 0.0%
src/domain/accounts/entities/create-account.dto.entity.ts 2 3 66.67%
src/datasources/accounts/accounts.datasource.ts 2 11 18.18%
Files with Coverage Reduction New Missed Lines %
src/datasources/accounts/accounts.datasource.ts 2 17.98%
Totals Coverage Status
Change from base Build 10717115016: -0.004%
Covered Lines: 4842
Relevant Lines: 8460
💛 - Coveralls

@hectorgomezv
Copy link
Member Author

Closing this as it's outdated and the feature is not being actively developed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hectorgomezv hectorgomezv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[User Accounts] Add name to account
2 participants
@hectorgomezv @coveralls