Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update SCSS files. #36

Open
benwiley4000 opened this issue May 2, 2016 · 1 comment
Open

Please update SCSS files. #36

benwiley4000 opened this issue May 2, 2016 · 1 comment

Comments

@benwiley4000
Copy link
Contributor

benwiley4000 commented May 2, 2016

The SCSS code does not match the LESS code. For example, the "icono-next" class:

/* next.less */
.icono-next{
    width: 0;
    height: 0;
    border: @10 solid transparent;
    border-left: @10 solid;
    border-right: none;
    margin: @7 @14 @7 @10;
    box-shadow: @4 0;
}
/* next.scss */
.icono-next{
    width: 0;
    height: 0;
    border: $U10 solid transparent;
    border-left: $U10 solid;
    margin: $U7;
    &:before{
        position: absolute;
        left: 0;
        top: -$U10;
        width: 0;
        height: 0;
        border-width: $U10 $U3 $U10 $U3;
        border-style: solid;
    }
}

I was wondering why my icon wasn't rendering correctly - then I went into the developer console, changed styles to match the LESS rules, and it worked. Don't know why bad styles are left over in the SCSS code, but it would be great if they stayed in sync.

Perhaps there should be a build-time test script that checks if the SCSS and LESS compiled output are identical, and displays a warning if not.

@hemedani
Copy link

hemedani commented Oct 6, 2016

I preferred add Stylus version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants