-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Note accidental gets 'undefined' sometimes (accidentalValue() > 2) #107
Comments
eagor
changed the title
Note accidental might be 'undefined' sometimes
Note accidental gets 'undefined' sometimes (accidentalValue() > 3)
Apr 20, 2016
eagor
changed the title
Note accidental gets 'undefined' sometimes (accidentalValue() > 3)
Note accidental gets 'undefined' sometimes (accidentalValue() > 2)
Apr 20, 2016
so this is it:
but seems to be like note name has to be F (as 4th note after C) |
Yes. that's the problem. I don't think there's an answer for that - since we generally speaking never deal in "triple accidentals" like that. I think throwing an error would be best - since you're trying to do something "impossible" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I suspect this is a result of Note#accidental()
But the accidentalValue should not be greater than 2. If it is, then it should be another note name. Thus I think the root of the issue is in the way the intervals are calculated, particularly, how it finds the note that is some interval away from another note (from scale tonic in our case).
The text was updated successfully, but these errors were encountered: