Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousel gallery transition errors #1643

Closed
trouba opened this issue Jun 19, 2024 · 2 comments
Closed

Carousel gallery transition errors #1643

trouba opened this issue Jun 19, 2024 · 2 comments
Labels

Comments

@trouba
Copy link

trouba commented Jun 19, 2024

Description

Errors when interacting with the picture before it's loaded on the gallery carousel

Steps to reproduce

Can be reproduced on the demo page: https://www.lightgalleryjs.com/demos/carousel-gallery/

  • On the carousel gallery
  • When switching between two pictures
  • Click or touch the loading area (before the new pictures appears)
  • Multiple errors appear:
TypeError: undefined is not an object (evaluating '$image.getBoundingClientRect')
TypeError: undefined is not an object (evaluating '$image.get().getBoundingClientRect')
TypeError: undefined is not an object (evaluating '$image.get().offsetWidth')

It fires up a lot on mobile when switching through image if they are heavy and don't load quickly
When using sentry, thousands of these errors appears in our logs

This is the same issue as this one #1485 but can easily be reproduced on the demos so I think it's worth investigating

@trouba
Copy link
Author

trouba commented Jul 3, 2024

It seems like these errors will be fixed in the 2.8.0, any news on when it will be out of beta @sachinchoolur ?

https://github.com/sachinchoolur/lightGallery/releases/tag/2.8.0-beta.2

Copy link

stale bot commented Sep 2, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the v1 label Sep 2, 2024
@stale stale bot closed this as completed Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant