New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If Listener is not set, Null Ref occurs #36

Open

phillijw opened this issue Oct 27, 2023 · 0 comments

phillijw commented Oct 27, 2023 •

edited

https://github.com/sacOO7/SocketclusterClientDotNet/blob/4013bada049d4c17506343fac0c61bf32f3bb583/ScClient/Socket.cs#L117C34-L117C41

I see two ways around this:

Set a default Listener in the constructor that just doesn't do anything
Check if the listener is null and throw a better exception than a null ref (or don't call the listener which would get annoying to do in every spot)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment