Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image croping (clipping) #1088

Open
QubaB opened this issue Jan 1, 2024 · 0 comments · May be fixed by #1136
Open

Image croping (clipping) #1088

QubaB opened this issue Jan 1, 2024 · 0 comments · May be fixed by #1136
Labels
enhancement New feature or request

Comments

@QubaB
Copy link
Contributor

QubaB commented Jan 1, 2024

Motivation

I would like to implement image crop/clip. Before I start programming I would like to ask if somebody is working on it.

For my purposes is sufficient clip image by rectangle. If somebody needs more sophisticated clip by path please let me know.

Solution

I would like to ask @adil192 if it is necessary to meet any conditions regarding the extension of EditorImage/PngEditorImage class and the implementation of images.

It is not clear to me from the source code meaning of EditorImage.naturalSize and EditorImage.srcRect. It seems to me that in PngEditorImage is naturalSize derived from srcRect. Which of these should contain original size of image?

Alternatives

No response

Saber version

v0.19.0

Device

any device

Anything else?

No response
@QubaB QubaB added the enhancement New feature or request label Jan 1, 2024
@QubaB QubaB linked a pull request Feb 23, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Crop images QubaB/saber
1 participant
@QubaB