StackOverflowError when using Spring 4.3 #184

henrik242 · 2016-07-06T07:45:20Z

I am trying to upgrade to Spring 4.3.0, but I am unable to initialize the spring context:

[ERROR] 09:25:31  Context initialization failed []
org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'healthCheckBeanPostProcessor' defined in class path resource [com/ryantenney/metrics/spring/config/annotation/DelegatingMetricsConfiguration.class]: Bean instantiation via factory method failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [org.springframework.beans.factory.config.BeanPostProcessor]: Factory method 'healthCheckBeanPostProcessor' threw exception; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'getHealthCheckRegistry' defined in class path resource [com/ryantenney/metrics/spring/config/annotation/DelegatingMetricsConfiguration.class]: Bean instantiation via factory method failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [com.codahale.metrics.health.HealthCheckRegistry]: Factory method 'getHealthCheckRegistry' threw exception; nested exception is java.lang.IllegalStateException: Failed to introspect annotations on public com.codahale.metrics.health.HealthCheckRegistry com.ryantenney.metrics.spring.config.annotation.DelegatingMetricsConfiguration.getHealthCheckRegistry()
    at org.springframework.beans.factory.support.ConstructorResolver.instantiateUsingFactoryMethod(ConstructorResolver.java:599) ~[spring-beans-4.3.0.RELEASE.jar:4.3.0.RELEASE]
    at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.instantiateUsingFactoryMethod(AbstractAutowireCapableBeanFactory.java:1123) ~[spring-beans-4.3.0.RELEASE.jar:4.3.0.RELEASE]
    at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBeanInstance(AbstractAutowireCapableBeanFactory.java:1018) ~[spring-beans-4.3.0.RELEASE.jar:4.3.0.RELEASE]
[... more stuff ...]
Caused by: java.lang.StackOverflowError
    at java.lang.reflect.Method.hashCode(Method.java:330) ~[?:1.8.0_65]
    at java.util.HashMap.hash(HashMap.java:338) ~[?:1.8.0_65]
    at java.util.HashMap.put(HashMap.java:611) ~[?:1.8.0_65]
    at java.util.HashSet.add(HashSet.java:219) ~[?:1.8.0_65]
    at org.springframework.core.annotation.AnnotatedElementUtils.searchWithFindSemantics(AnnotatedElementUtils.java:1119) ~[spring-core-4.3.0.RELEASE.jar:4.3.0.RELEASE]
    at org.springframework.core.annotation.AnnotatedElementUtils.searchWithFindSemantics(AnnotatedElementUtils.java:1183) ~[spring-core-4.3.0.RELEASE.jar:4.3.0.RELEASE]
    at org.springframework.core.annotation.AnnotatedElementUtils.searchWithFindSemantics(AnnotatedElementUtils.java:1208) ~[spring-core-4.3.0.RELEASE.jar:4.3.0.RELEASE]
    at org.springframework.core.annotation.AnnotatedElementUtils.searchWithFindSemantics(AnnotatedElementUtils.java:1086) ~[spring-core-4.3.0.RELEASE.jar:4.3.0.RELEASE]
    at org.springframework.core.annotation.AnnotatedElementUtils.searchWithFindSemantics(AnnotatedElementUtils.java:1060) ~[spring-core-4.3.0.RELEASE.jar:4.3.0.RELEASE]
    at org.springframework.core.annotation.AnnotatedElementUtils.findMergedAnnotationAttributes(AnnotatedElementUtils.java:656) ~[spring-core-4.3.0.RELEASE.jar:4.3.0.RELEASE]
    at org.springframework.core.annotation.AnnotatedElementUtils.findMergedAnnotation(AnnotatedElementUtils.java:730) ~[spring-core-4.3.0.RELEASE.jar:4.3.0.RELEASE]
    at org.springframework.context.annotation.ConfigurationClassEnhancer$BeanMethodInterceptor.intercept(ConfigurationClassEnhancer.java:314) ~[spring-context-4.3.0.RELEASE.jar:4.3.0.RELEASE]
    at com.ryantenney.metrics.spring.config.annotation.DelegatingMetricsConfiguration$$EnhancerBySpringCGLIB$$2cc24d5e.getHealthCheckRegistry(<generated>) ~[metrics-spring-3.1.3.jar:?]
    at com.ryantenney.metrics.spring.config.annotation.MetricsConfigurerComposite.getHealthCheckRegistry(MetricsConfigurerComposite.java:68) ~[metrics-spring-3.1.3.jar:?]
    at com.ryantenney.metrics.spring.config.annotation.DelegatingMetricsConfiguration.getHealthCheckRegistry(DelegatingMetricsConfiguration.java:69) ~[metrics-spring-3.1.3.jar:?]
    at com.ryantenney.metrics.spring.config.annotation.DelegatingMetricsConfiguration$$EnhancerBySpringCGLIB$$2cc24d5e.CGLIB$getHealthCheckRegistry$3(<generated>) ~[metrics-spring-3.1.3.jar:?]
    at com.ryantenney.metrics.spring.config.annotation.DelegatingMetricsConfiguration$$EnhancerBySpringCGLIB$$2cc24d5e$$FastClassBySpringCGLIB$$7853f663.invoke(<generated>) ~[metrics-spring-3.1.3.jar:?]
    at org.springframework.cglib.proxy.MethodProxy.invokeSuper(MethodProxy.java:228) ~[spring-core-4.3.0.RELEASE.jar:4.3.0.RELEASE]
    at org.springframework.context.annotation.ConfigurationClassEnhancer$BeanMethodInterceptor.intercept(ConfigurationClassEnhancer.java:356) ~[spring-context-4.3.0.RELEASE.jar:4.3.0.RELEASE]
    at com.ryantenney.metrics.spring.config.annotation.DelegatingMetricsConfiguration$$EnhancerBySpringCGLIB$$2cc24d5e.getHealthCheckRegistry(<generated>) ~[metrics-spring-3.1.3.jar:?]
    at com.ryantenney.metrics.spring.config.annotation.MetricsConfigurerComposite.getHealthCheckRegistry(MetricsConfigurerComposite.java:68) ~[metrics-spring-3.1.3.jar:?]
    at com.ryantenney.metrics.spring.config.annotation.DelegatingMetricsConfiguration.getHealthCheckRegistry(DelegatingMetricsConfiguration.java:69) ~[metrics-spring-3.1.3.jar:?]
    at com.ryantenney.metrics.spring.config.annotation.DelegatingMetricsConfiguration$$EnhancerBySpringCGLIB$$2cc24d5e.CGLIB$getHealthCheckRegistry$3(<generated>) ~[metrics-spring-3.1.3.jar:?]
    at com.ryantenney.metrics.spring.config.annotation.DelegatingMetricsConfiguration$$EnhancerBySpringCGLIB$$2cc24d5e$$FastClassBySpringCGLIB$$7853f663.invoke(<generated>) ~[metrics-spring-3.1.3.jar:?]
    [... repeat 100 times ...]
    at org.springframework.cglib.proxy.MethodProxy.invokeSuper(MethodProxy.java:228) ~[spring-core-4.3.0.RELEASE.jar:4.3.0.RELEASE]
    at org.springframework.context.annotation.ConfigurationClassEnhancer$BeanMethodInterceptor.intercept(ConfigurationClassEnhancer.java:356) ~[spring-context-4.3.0.RELEASE.jar:4.3.0.RELEASE]
    at com.ryantenney.metrics.spring.config.annotation.DelegatingMetricsConfiguration$$EnhancerBySpringCGLIB$$2cc24d5e.getHealthCheckRegistry(<generated>) ~[metrics-spring-3.1.3.jar:?]
    at com.ryantenney.metrics.spring.config.annotation.MetricsConfigurerComposite.getHealthCheckRegistry(MetricsConfigurerComposite.java:68) ~[metrics-spring-3.1.3.jar:?]
    at com.ryantenney.metrics.spring.config.annotation.DelegatingMetricsConfiguration.getHealthCheckRegistry(DelegatingMetricsConfiguration.java:69) ~[metrics-spring-3.1.3.jar:?]
    at com.ryantenney.metrics.spring.config.annotation.DelegatingMetricsConfiguration$$EnhancerBySpringCGLIB$$2cc24d5e.CGLIB$getHealthCheckRegistry$3(<generated>) ~[metrics-spring-3.1.3.jar:?]
    at com.ryantenney.metrics.spring.config.annotation.DelegatingMetricsConfiguration$$EnhancerBySpringCGLIB$$2cc24d5e$$FastClassBySpringCGLIB$$7853f663.invoke(<generated>) ~[metrics-spring-3.1.3.jar:?]

The text was updated successfully, but these errors were encountered:

henrik242 · 2016-07-06T12:38:14Z

Seems to happen when a @Configuration class is annotated with @EnableMetrics. I get the same result in Spring 4.3.1.

ryantenney · 2016-07-06T14:40:19Z

Which stack frame or set of stack frames repeats 100 times?

henrik242 · 2016-07-06T15:32:21Z

Not exactly a hundred, but several dozens:

    at org.springframework.cglib.proxy.MethodProxy.invokeSuper(MethodProxy.java:228) ~[spring-core-4.3.0.RELEASE.jar:4.3.0.RELEASE]
    at org.springframework.context.annotation.ConfigurationClassEnhancer$BeanMethodInterceptor.intercept(ConfigurationClassEnhancer.java:356) ~[spring-context-4.3.0.RELEASE.jar:4.3.0.RELEASE]
    at com.ryantenney.metrics.spring.config.annotation.DelegatingMetricsConfiguration$$EnhancerBySpringCGLIB$$2cc24d5e.getHealthCheckRegistry(<generated>) ~[metrics-spring-3.1.3.jar:?]
    at com.ryantenney.metrics.spring.config.annotation.MetricsConfigurerComposite.getHealthCheckRegistry(MetricsConfigurerComposite.java:68) ~[metrics-spring-3.1.3.jar:?]
    at com.ryantenney.metrics.spring.config.annotation.DelegatingMetricsConfiguration.getHealthCheckRegistry(DelegatingMetricsConfiguration.java:69) ~[metrics-spring-3.1.3.jar:?]
    at com.ryantenney.metrics.spring.config.annotation.DelegatingMetricsConfiguration$$EnhancerBySpringCGLIB$$2cc24d5e.CGLIB$getHealthCheckRegistry$3(<generated>) ~[metrics-spring-3.1.3.jar:?]
    at com.ryantenney.metrics.spring.config.annotation.DelegatingMetricsConfiguration$$EnhancerBySpringCGLIB$$2cc24d5e$$FastClassBySpringCGLIB$$7853f663.invoke(<generated>) ~[metrics-spring-3.1.3.jar:?]

henrik242 · 2016-07-07T08:48:36Z

@ryantenney Are you able to reproduce it, and/or do you need more info from me?

henrik242 · 2016-07-07T12:16:48Z

I'm trying to understand what @EnableMetrics does. Is it only used to enable scanning of the @Metric annotation?

rafal-glowinski · 2016-07-15T11:24:33Z

    at org.springframework.context.annotation.ConfigurationClassEnhancer$BeanMethodInterceptor.intercept(ConfigurationClassEnhancer.java:356) ~[spring-context-4.3.1.RELEASE.jar:4.3.1.RELEASE]
    at com.ryantenney.metrics.spring.config.annotation.DelegatingMetricsConfiguration$$EnhancerBySpringCGLIB$$2c4ac852.getMetricRegistry(<generated>) ~[metrics-spring-3.1.3.jar:na]
    at com.ryantenney.metrics.spring.config.annotation.MetricsConfigurerComposite.getMetricRegistry(MetricsConfigurerComposite.java:52) ~[metrics-spring-3.1.3.jar:na]
    at com.ryantenney.metrics.spring.config.annotation.DelegatingMetricsConfiguration.getMetricRegistry(DelegatingMetricsConfiguration.java:59) ~[metrics-spring-3.1.3.jar:na]
    at com.ryantenney.metrics.spring.config.annotation.DelegatingMetricsConfiguration$$EnhancerBySpringCGLIB$$2c4ac852.CGLIB$getMetricRegistry$2(<generated>) ~[metrics-spring-3.1.3.jar:na]
    at com.ryantenney.metrics.spring.config.annotation.DelegatingMetricsConfiguration$$EnhancerBySpringCGLIB$$2c4ac852$$FastClassBySpringCGLIB$$2acb39f3.invoke(<generated>) ~[metrics-spring-3.1.3.jar:na]
    at org.springframework.cglib.proxy.MethodProxy.invokeSuper(MethodProxy.java:228) ~[spring-core-4.3.1.RELEASE.jar:4.3.1.RELEASE]

It happens during the call to: "com.ryantenney.metrics.spring.config.annotation.DelegatingMetricsConfiguration#getMetricRegistry" because "delegates" contain an instance of "DelegatingMetricsConfiguration" which causes Stack Overflow.

roykachouh · 2016-07-16T16:10:02Z

Yes, this is happening for me as well. I upgrade to boot 1.4.x and the MetricRegistry bean can no longer create. It looks like recursion in the DelegatingMetricsConfiguration#getMetricRegistry.

Metric registry is null, and the delegates recurse.

ryantenney · 2016-07-16T16:25:58Z

@roykachouh @henrik242 @rafal-glowinski do any of you have AspectJ Autoproxying enabled?

henrik242 · 2016-07-17T14:38:39Z

@ryantenney Nope, not that I'm aware of.

roykachouh · 2016-07-26T20:39:14Z

@ryantenney thanks for looking into this...no i don't have aspectj autoproxying enabled...i even tried disabling the auto-configuration just in case...but to no avail, the stack still overflows...

spring:
  aop:
    auto: false

chornyi · 2016-08-03T21:46:32Z

For now I "fixed" this by removing @EnableMetrics and adding this:

@Configuration
public class CustomDelegatingMetricsConfiguration extends DelegatingMetricsConfiguration {

    @Override
    @Autowired(required = false)
    public void setMetricsConfigurers(final List<MetricsConfigurer> configurers) {
    }
}

roykachouh · 2016-08-03T22:29:19Z

Yep, temporarily got around it by removing EnableMetrics

On Wed, Aug 3, 2016 at 5:46 PM Dmitry Chornyi [email protected]
wrote:

For now I "fixed" this by removing @EnableMetrics and adding this:

@configuration
public class CustomDelegatingMetricsConfiguration extends DelegatingMetricsConfiguration {
@Override
@Autowired(required = false)
public void setMetricsConfigurers(final List<MetricsConfigurer> configurers) {
}
}

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#184 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB_QXtAcdNMOW1K82bsmqZ2kUxtsIaLyks5qcQw7gaJpZM4JF1GW
.

hello-josh · 2016-09-12T15:24:14Z

I'm having the same issue and it looks like it is because the @EnableMetrics annotation does not work correctly on a @Configuration POJO.

This works:

@Configuration
@EnableMetrics
public class MetricsConfig extends MetricsConfigurerAdapter {
}

This does not and causes the stack overflow

@Configuration
@EnableMetrics
public class MetricsConfig {
}

This repo illustrates it: https://github.com/Trii/SpringBootMetricsSpringBug
Clone and run gradle bootRun to see the stackoverflow. Open src/main/java/trii/SampleConfig.java and uncomment the import and extends to see it working.

Maybe this is intended behavior and more of a usage error.

sfussenegger · 2016-11-29T11:42:19Z

I ran into the same problem. I've tracked the issue down to DelegatingMetricsConfiguration.setMetricsConfigurers(List<MetricsConfigurer> configurers). The issue is that configurers contains itself (i.e. this), obviously a big no-no for a list of delegates. There must have been a change in Spring 1.4 that allows autowiring objects with themselves.

The simplest solution therefore seems to be not to implement MetricsConfigurer in DelegatingMetricsConfiguration

…ixes ryantenney#184)

laur89 · 2017-06-27T10:03:54Z

This issue should be closed, as it doesn't reproduce with spring 4.3.7 (spring boot 1.5.X).

nickcodefresh mentioned this issue Aug 26, 2016

Not working when upgrading to Spring Boot 1.4 #189

Open

dkatzberg mentioned this issue Sep 28, 2016

Upgrade Spring Boot to 1.4.2 (pom.xml) dzhw/metadatamanagement#706

Closed

sfussenegger added a commit to molindo/metrics-spring that referenced this issue Nov 29, 2016

don't implement MetricsConfigurer in DelegatingMetricsConfiguration (f…

e98631f

…ixes ryantenney#184)

sfussenegger linked a pull request Nov 29, 2016 that will close this issue

don't implement MetricsConfigurer in DelegatingMetricsConfiguration #192

Open

slnowak mentioned this issue Dec 23, 2016

StackOverflowError when using @EnableMetrics with spring-boot 1.4.2 #193

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

StackOverflowError when using Spring 4.3 #184

StackOverflowError when using Spring 4.3 #184

henrik242 commented Jul 6, 2016 •

edited

Loading

henrik242 commented Jul 6, 2016 •

edited

Loading

ryantenney commented Jul 6, 2016

henrik242 commented Jul 6, 2016 •

edited

Loading

henrik242 commented Jul 7, 2016

henrik242 commented Jul 7, 2016

rafal-glowinski commented Jul 15, 2016

roykachouh commented Jul 16, 2016

ryantenney commented Jul 16, 2016

henrik242 commented Jul 17, 2016

roykachouh commented Jul 26, 2016 •

edited

Loading

chornyi commented Aug 3, 2016

roykachouh commented Aug 3, 2016

hello-josh commented Sep 12, 2016 •

edited

Loading

sfussenegger commented Nov 29, 2016 •

edited

Loading

laur89 commented Jun 27, 2017

StackOverflowError when using Spring 4.3 #184

StackOverflowError when using Spring 4.3 #184

Comments

henrik242 commented Jul 6, 2016 • edited Loading

henrik242 commented Jul 6, 2016 • edited Loading

ryantenney commented Jul 6, 2016

henrik242 commented Jul 6, 2016 • edited Loading

henrik242 commented Jul 7, 2016

henrik242 commented Jul 7, 2016

rafal-glowinski commented Jul 15, 2016

roykachouh commented Jul 16, 2016

ryantenney commented Jul 16, 2016

henrik242 commented Jul 17, 2016

roykachouh commented Jul 26, 2016 • edited Loading

chornyi commented Aug 3, 2016

roykachouh commented Aug 3, 2016

hello-josh commented Sep 12, 2016 • edited Loading

sfussenegger commented Nov 29, 2016 • edited Loading

laur89 commented Jun 27, 2017

henrik242 commented Jul 6, 2016 •

edited

Loading

henrik242 commented Jul 6, 2016 •

edited

Loading

henrik242 commented Jul 6, 2016 •

edited

Loading

roykachouh commented Jul 26, 2016 •

edited

Loading

hello-josh commented Sep 12, 2016 •

edited

Loading

sfussenegger commented Nov 29, 2016 •

edited

Loading