Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add date filtering to browse/KEYWORD view #96

Open
ohadschn opened this issue Nov 26, 2017 · 4 comments
Open

Add date filtering to browse/KEYWORD view #96

ohadschn opened this issue Nov 26, 2017 · 4 comments

Comments

@ohadschn
Copy link

ohadschn commented Nov 26, 2017

SoundCloud's default sorting algorithm, as well as sorting by plays/likes/reposts heavily favor old tracks (since they had a lot of time to gain popularity). For example, the first track on the main favesound page is four years old!

It would be great to have the option to filter by date, like SoundCloud allows ("past year", "past month" and so forth).

This isn't an issue when logging in, because the home feed is sorted by date by default.

@VikasDayananda
Copy link

Hey @rwieruch , can you assign me to this?

@rwieruch
Copy link
Owner

Sure. Looking forward to your implementation :)

VikasDayananda pushed a commit to VikasDayananda/favesound-redux that referenced this issue Oct 21, 2018
@VikasDayananda
Copy link

@rwieruch I went ahead and implemented the data sorting. Currently, we can sort by last "6 months", "a year", or "older than that". We can always add more options to it which fits our data best. Did not include "Past Month" because there is very less or almost no tracks for that filter. Currently, it looks like this. Also, the sort functions only works for first set of activities we see. We will have to scroll through entire data for it to work for all. Any way of improving this? Please suggest.

favesound

@VikasDayananda
Copy link

@rwieruch Created PR #127

rwieruch added a commit that referenced this issue Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants