Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework select and multi-select #182

Open
rvion opened this issue Feb 29, 2024 · 4 comments
Open

rework select and multi-select #182

rvion opened this issue Feb 29, 2024 · 4 comments
Assignees

Comments

@rvion
Copy link
Owner

rvion commented Feb 29, 2024

No description provided.

@rvion
Copy link
Owner Author

rvion commented Feb 29, 2024

misc list of todo and broken things

  • make sure tab navigation work fine
  • fix multi-select
  • add ways to re-open / re-close with space, enter, and other regular keyboard shortcuts
  • when multi-select open with more value that fit a single line => make it easy to see all options with wrapping
  • keep all active options visible at all times regardless of filter
  • remove most visual differences between single/multi-select (less code to maintain)
  • fix the MouseMoveTooFar detection that do not
  • add a way to remove previously select but not-existing anymore options
  • keep options labels in sync (only using cached id if not present)

@rvion rvion self-assigned this Feb 29, 2024
@rvion
Copy link
Owner Author

rvion commented Feb 29, 2024

manually selecting an option should instantly focus back the filter input so tab still work, and so we can start looking for an other option

@birdddev
Copy link
Collaborator

fix the MouseMoveTooFar detection that do not

// | this code was a good idea; but it's really
// | not pleasant when working mostly with keyboard and using tab to open selects.
// | as soon as the moouse move just one pixel, popup close.
// |  =>  commenting it out until we find a solution confortable in all cases

Good catch.
Only close if the mouse becomes within distance first, and then leaves the distance.

@rvion
Copy link
Owner Author

rvion commented Feb 29, 2024

Yes, planned to do that 👍, i have a bunch of unstaged changes locally; will push them this evening

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Started
Development

No branches or pull requests

2 participants