Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up #582

Open
4 of 5 tasks
AlexEne opened this issue Aug 6, 2021 · 1 comment
Open
4 of 5 tasks

Clean up #582

AlexEne opened this issue Aug 6, 2021 · 1 comment
Assignees

Comments

@AlexEne
Copy link
Collaborator

AlexEne commented Aug 6, 2021

I'm opening this to provide some visibility on what I'm working on.
The repo is a bit stale and requires some care before we can add some new features (e.g. I'm excited about #581, I have some prototype, it's easy to use and has super nice results).

But before we can have nice shiny things some cleanup must be done:

  • Enable github actions: Github actions #580
  • Run the tests on windows (part of task above). Now I need to work in WSL on my machine and it's a bit of a pain as the wrong \r\n in a .sh file confuses up test script :)
  • Update dependencies: This will be a bit of a pain as dependabot is trying, but I've manually checked some of them and they don't compile. Not having a working CI isn't ideal either.
  • Add lib.rs clippy deny lints with deny so we keep this as idiomatic as possible.
  • Remove failure dependency. This is probably from a time when main couldn't return a Result.

I'll add more stuff if I find it, but so far this seems like a good plan.

@AlexEne AlexEne self-assigned this Aug 6, 2021
@AlexEne
Copy link
Collaborator Author

AlexEne commented Jun 7, 2022

Removing the failure dependency seems to be more pressing as this is now open: https://github.com/rustwasm/twiggy/security/dependabot/1

I don't think we're getting any benefit from using it vs this_error / anyhow, so I'll just move to depend on those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant