-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ?Sized bounds or add CI test that they work #195
Comments
Is there any explicit refactoring that doesn't work with I think it only works on Nightly, but there I think you can coerce an |
I don't think it should be an issue with anything, but It's also possible to use |
I don't think Rust could allow a coercion from I think if it's possible we'd at least need to provide some kind of conversion for that to work. And I don't know exactly how that works when we have a boxed/ref-counted custom unsized type containing the |
#132 added trait bonds with
?Sized
.Context<dyn HasDisplayHandle>
was mentioned there, but if you try to specify that type anywhere, it errors becauseContext
andContextDispatch
do not haveD: ?Sized
bounds. So the public API doesn't actually allow that.Adding those bounds is easy, but is there a way to construct a
Context<dyn HasDisplayHandle>
?If
?Sized
is useful, we should make sure it works and have a test that it continues working on all platforms. Otherwise, it can be removed, which may make other refactoring easier.CC @notgull
The text was updated successfully, but these errors were encountered: