We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There are some DisplayHandle and WindowHandle variants that are completely safe to construct. For instance:
DisplayHandle
WindowHandle
[Xlib/Xcb]DisplayHandle
None
Win32WindowHandle
[Xlib/Xcb]WindowHandle
It should be possible to construct these safely, with constructors on the safe types.
The text was updated successfully, but these errors were encountered:
The reason everything in unsafe is forward compat, I guess? Because unsafe -> safe is a breaking change, but not otherwise.
unsafe
Sorry, something went wrong.
Also, isn't Default basically it?
Default
I was thinking more along these lines:
impl DisplayHandle<'static> { pub fn windows() -> Self { unsafe { Self::borrow_raw(WindowsDisplayHandle::new().into()) } } pub fn xlib_no_display() -> Self { unsafe { Self::borrow_raw(XlibDisplayHandle::new(None).into()) } } }
Basically, to allow for more ways of creating DisplayHandle and WindowHandle without needing to go through borrow_raw.
borrow_raw
No branches or pull requests
There are some
DisplayHandle
andWindowHandle
variants that are completely safe to construct. For instance:DisplayHandle
s are just indicators of the currently running display system and don't involve any borrowed state.[Xlib/Xcb]DisplayHandle
with a display ofNone
can be constructed safely.Win32WindowHandle
,[Xlib/Xcb]WindowHandle
and WASM web handles involve window IDs with no borrowed state.It should be possible to construct these safely, with constructors on the safe types.
The text was updated successfully, but these errors were encountered: