Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCA works only for f64 #232

Open
jorgehermo9 opened this issue Jul 29, 2022 · 3 comments
Open

PCA works only for f64 #232

jorgehermo9 opened this issue Jul 29, 2022 · 3 comments

Comments

@jorgehermo9
Copy link
Contributor

jorgehermo9 commented Jul 29, 2022

PCA algorithm is only implemented for f64. Is there a reason for this? Can't it be implemented for trait Float?

@EricTulowetzke
Copy link

I can take look at this over the next few days if no one else wants too

@bytesnake
Copy link
Member

bytesnake commented Aug 3, 2022

Depends on rust-ndarray/ndarray-linalg#275, this is already possible in the native Rust implementation but for fast LAPACK not yet

@YuhanLiin
Copy link
Collaborator

While the f32 impl would be broken when we use LAPACK, by default we use the pure-Rust linalg library instead, so f32 should work. I'll see if I can enable f32 for the pure-Rust library only without too much copypaste.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants