feat: setup bootstrap and ci #3

Wybxc · 2024-09-19T12:26:54Z

This pull request sets up the bootstrap process and CI for the C codegen backend.

jieyouxu

I left some minor nits. I also have a question for this backend: is there a reason why you need to reinvent a bootstrap instead of forking the rust repo then adding additional logic as necessary?

EDIT: to clarify, it's entirely possible that you have very good reasons or run into difficult limitations for doing so. I'm asking because using Yet Another Bootstrap makes (1) upstreaming the backend very very difficult and (2) makes it more difficult for other rustc contributors who wants to make changes to this backend because they have to deal with the intricacies of Yet Another Build System.

jieyouxu · 2024-09-19T12:56:47Z

bootstrap/.gitignore

@@ -0,0 +1 @@
+/target


Nit: can you make sure the files have trailing newlines because I think some Unix tools assume trailing newlines exist?

Per the GH UI, these are still missing. Just look at the diff view and make sure none of the files have that symbol.

@jieyouxu did you mean to mark this as resolved? Looks like they are still there

Oh, or maybe you had it resolved before and I just commented without unresolving :)

Oh maybe I thought they were fixed, not sure

bootstrap/src/clean.rs

bootstrap/src/fmt.rs

bootstrap/src/test.rs

Wybxc · 2024-09-20T12:06:30Z

I left some minor nits. I also have a question for this backend: is there a reason why you need to reinvent a bootstrap instead of forking the rust repo then adding additional logic as necessary?我留下了一些小虱子。我对这个后端还有一个问题：是否有理由需要重新发明引导程序，而不是分叉rust存储库，然后根据需要添加额外的逻辑？

EDIT: to clarify, it's entirely possible that you have very good reasons or run into difficult limitations for doing so. I'm asking because using Yet Another Bootstrap makes (1) upstreaming the backend very very difficult and (2) makes it more difficult for other rustc contributors who wants to make changes to this backend because they have to deal with the intricacies of Yet Another Build System.编辑：澄清一下，您完全有可能有很好的理由或遇到困难的限制。我这么问是因为使用 Yet Another Bootstrap 会（1）使后端上游变得非常非常困难，并且（2）使其他想要更改此后端的 rustc 贡献者变得更加困难，因为他们必须处理 Yet Another 的复杂性构建系统。

In projects such as rustc_codegen_cranelift or rust_codegen_gcc, there exists a component referred to as the build_system, which serves a similar function to what is termed "bootstrap" in this context. It is important to distinguish this from the bootstrap process of the Rust compiler itself. In this instance, we assume the presence of an operational Rust compiler, and we merely encapsulate some command-line invocations to rustc, making rustc_codegen_c the default code generation option.

Wybxc · 2024-09-20T12:07:53Z

Refer to #2 (comment)

tgross35

I think this looks pretty good overall. Please just make sure absolute paths are used everywhere, otherwise it looks like a lot of things will break when running from a different directory.

Aside from that, a few other comments but I don't see any big issues.

tgross35 · 2024-09-20T15:01:40Z

bootstrap/.gitignore

@@ -0,0 +1 @@
+/target


Per the GH UI, these are still missing. Just look at the diff view and make sure none of the files have that symbol.

.github/workflows/main.yaml

bootstrap/src/clean.rs

bootstrap/src/fmt.rs

tgross35 · 2024-09-20T15:09:38Z

bootstrap/src/fmt.rs

+        }
+    }
+
+    pub fn perform(&self, command: &mut Command) {


Nit: perform and run should probably get different names since it isn't very obvious what the difference is. Or ideally, just put this into a trait so all steps are required to use the same interface.

Nonblocker though, this can be changed later.

bootstrap/src/main.rs

bootstrap/src/manifest.rs

bootstrap/src/test.rs

Wybxc · 2024-09-22T09:32:42Z

I think this looks pretty good overall. Please just make sure absolute paths are used everywhere, otherwise it looks like a lot of things will break when running from a different directory.

Aside from that, a few other comments but I don't see any big issues.

The use cases for bootstrap are typically highly specific to the project structure, making execution in alternative directories impractical. Additionally, the brevity of the ./y command serves as a clear reminder of the current working directory.

As far as I am aware, rustc_codegen_gcc also utilizes relative paths:
https://github.com/rust-lang/rustc_codegen_gcc/blob/3018d9dc8fc2fe19a0e7366166ceb6829d1b273d/build_system/src/clean.rs#L72
https://github.com/rust-lang/rustc_codegen_gcc/blob/3018d9dc8fc2fe19a0e7366166ceb6829d1b273d/build_system/src/main.rs#L16

Wybxc · 2024-09-24T01:56:44Z

@tgross35 Please check the latest changes.

tgross35 · 2024-09-24T13:06:28Z

Additionally, the brevity of the ./y command serves as a clear reminder of the current working directory.

Forgot this relaunches with the given directory, makes sense then.

@tgross35 Please check the latest changes.

There are a couple unresolved comments still. Specifically #3 (comment) so tools don't break (I guess that one was labeled resolved even though that might not have been accurate), and #3 (comment) to make one CLI option more consistent.

Other than that LGTM. This could be squashed, or I can just do it on merge.

Wybxc · 2024-09-25T09:52:09Z

Other than that LGTM. This could be squashed, or I can just do it on merge.

A squash merge seems like a good idea.

tgross35

Awesome, let's get this off the ground. Thanks!

feat: setup bootstrap and ci

c19d4b7

Wybxc mentioned this pull request Sep 19, 2024

Minimal codegen support: numbers and function parameters #2

Merged

jieyouxu reviewed Sep 19, 2024

View reviewed changes

Wybxc added 4 commits September 20, 2024 20:11

chore: remove useless Path::new

719d2aa

chore: endline

28e2411

fix: panic on clean

9ab2c93

fix: status check of fmt

0842a73

tgross35 reviewed Sep 20, 2024

View reviewed changes

feat: prefer new version of FileCheck

d962aab

Wybxc added 3 commits September 25, 2024 15:04

chore: rename debug to verbose

3d02864

chore: fix newline at eof

01efce2

chore: unify subcommand interface

c489f1e

tgross35 approved these changes Sep 25, 2024

View reviewed changes

tgross35 merged commit 38d9c4d into rust-lang:main Sep 25, 2024
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: setup bootstrap and ci #3

feat: setup bootstrap and ci #3

Wybxc commented Sep 19, 2024

jieyouxu left a comment •

edited

Loading

jieyouxu Sep 19, 2024

Wybxc Sep 20, 2024

tgross35 Sep 20, 2024

tgross35 Sep 24, 2024

tgross35 Sep 24, 2024

jieyouxu Sep 24, 2024

Wybxc commented Sep 20, 2024

Wybxc commented Sep 20, 2024

tgross35 left a comment

tgross35 Sep 20, 2024

tgross35 Sep 20, 2024

Wybxc commented Sep 22, 2024

Wybxc commented Sep 24, 2024

tgross35 commented Sep 24, 2024 •

edited

Loading

Wybxc commented Sep 25, 2024

tgross35 left a comment

		@@ -0,0 +1 @@
		/target

		@@ -0,0 +1 @@
		/target

feat: setup bootstrap and ci #3

feat: setup bootstrap and ci #3

Conversation

Wybxc commented Sep 19, 2024

jieyouxu left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Wybxc commented Sep 20, 2024

Wybxc commented Sep 20, 2024

tgross35 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Wybxc commented Sep 22, 2024

Wybxc commented Sep 24, 2024

tgross35 commented Sep 24, 2024 • edited Loading

Wybxc commented Sep 25, 2024

tgross35 left a comment

Choose a reason for hiding this comment

jieyouxu left a comment •

edited

Loading

tgross35 commented Sep 24, 2024 •

edited

Loading