Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue for Rust 2024: rustfmt raw identifier sorting #124764

Closed
3 tasks done
calebcartwright opened this issue May 5, 2024 · 2 comments
Closed
3 tasks done

Tracking Issue for Rust 2024: rustfmt raw identifier sorting #124764

calebcartwright opened this issue May 5, 2024 · 2 comments
Assignees
Labels
A-edition-2024 Area: The 2024 edition A-rustfmt Area: Rustfmt C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC S-tracking-ready-for-edition Status: This issue is ready for inclusion in the edition. T-style Relevant to the style team, which will review and decide on the PR/issue.

Comments

@calebcartwright
Copy link
Member

calebcartwright commented May 5, 2024

This is a tracking issue for correcting the sort order of imports that include raw identifiers in rustfmt. This is needed to support the Style Edition 2024 which is expected to be released with Rust 2024.

About tracking issues

Tracking issues are used to record the overall progress of implementation. They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions. A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature. Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

Steps

Unresolved Questions

None.

Implementation history

cc @rust-lang/rustfmt @rust-lang/style

Intended to cover rust-lang/rustfmt#5577 (comment)

@calebcartwright calebcartwright added C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC A-rustfmt Area: Rustfmt I-style-nominated Nominated for discussion during a style team meeting. T-style Relevant to the style team, which will review and decide on the PR/issue. A-edition-2024 Area: The 2024 edition labels May 5, 2024
@calebcartwright calebcartwright self-assigned this May 5, 2024
@traviscross traviscross added S-tracking-needs-documentation Status: Needs documentation. S-tracking-impl-incomplete Status: The implementation is incomplete. labels May 21, 2024
@calebcartwright calebcartwright removed the S-tracking-impl-incomplete Status: The implementation is incomplete. label Aug 21, 2024
@calebcartwright calebcartwright removed the S-tracking-needs-documentation Status: Needs documentation. label Nov 3, 2024
@calebcartwright
Copy link
Member Author

Dropping the needs-doc label given that rust-lang/edition-guide#321 was merged

@traviscross
Copy link
Contributor

@rustbot labels +S-tracking-ready-for-edition -I-style-nominated

We reviewed this on the edition call. This is now ready for Rust 2024.

Thanks to @calebcartwright and the rest of the rustfmt team and style team for pushing this forward.

@rustbot rustbot added S-tracking-ready-for-edition Status: This issue is ready for inclusion in the edition. and removed I-style-nominated Nominated for discussion during a style team meeting. labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-edition-2024 Area: The 2024 edition A-rustfmt Area: Rustfmt C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC S-tracking-ready-for-edition Status: This issue is ready for inclusion in the edition. T-style Relevant to the style team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants