-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
web-server: add compression #2271
Comments
We'd also need to have TLS in the container if it is exposed to the internet, but I assume we're still having it only accessed by cloudfront over a private network so that shouldn't be necessary. |
Yep, that's my thinking, our webservers would only be accessed through CloudFront, so we don't have to do TLS |
And especially between the US & CF POPs in europe / asia compression definitely makes a difference |
Hi! I'd like to take a stab at solving this by adding a compression layer to the middleware stack in the web server. If that's ok, I have a couple of questions:
|
Very good question!
|
When using tower-http compression, see the comments / change here : rust-lang/crates.io#7330 |
Having read a little more about it I would say we should enable brotli, when easily possible. We first would add this to our webserver, and then probably need to change CloudFront config to support this, or use it between the browser and the CDN POP. |
In my mind, this could be solved via:
I assume axum is fine being exposed to the internet and doesn't need to be behind a reverse proxy (?).
Also in our current NGINX config: IP blocks, while it's unclear if we would handle this in AWS / CloudFront, or if we would have to handle this in our webserver (see rust-lang/simpleinfra#353)
The text was updated successfully, but these errors were encountered: