Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misleading explanation of comma in $(),* #3800

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pitaj
Copy link

@pitaj pitaj commented Dec 22, 2023

The previous explanation makes it sound like the comma in that place would match an optional trailing comma like in [a, b, c,]. That is incorrect, and actually that only matches commas between elements.

Motivation: https://stackoverflow.com/q/77701292/847382

The previous explanation makes it sound like the comma in that place would match an optional trailing comma like in `[a, b, c,]`. That is incorrect, and actually that only matches commas between elements.
Copy link
Contributor

@chriskrycho chriskrycho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is reasonably well-motivated; I see why it confused the Stack Overflow user. I want to think a little about phrasing here—your suggestion is good, but this is a little tricky and I want to make sure we get it just right!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants