Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load_wallet is not tested #238

Open
tcharding opened this issue Aug 17, 2022 · 1 comment
Open

load_wallet is not tested #238

tcharding opened this issue Aug 17, 2022 · 1 comment

Comments

@tcharding
Copy link
Member

Context

We have a few functions that are not tested, some of these (e.g., load_wallet) require starting bitcoind running an RPC command, restarting bitcoind and verifying the desired state.

Possible solution

  • Add a second binary to the integration test crate which calls the methods to test that require a restart (could use command line args so the same crate can run the command and run the verification command (i.e., cargo run -- --load-wallet and cargo run -- --verify-load-wallet)
  • Patch the run.sh script to start bitcoind run the new crate with --load-wallet
  • and restart bitcoind and run crate with --verify-load-wallet

There may be other ways to solve this, feel free to be creative.

@Anyitechs
Copy link

Hi @tcharding, thank you for the comment. Your proposed solution is quite brilliant, and I'll like to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants