-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Compatibility with Workload Identity Federation #293
Comments
Thanks for filing this @ccjernigan and for the details. This stack trace actually comes from flank itself here: https://github.com/Flank/flank/blob/master/test_runner/src/main/kotlin/ftl/args/ArgsHelper.kt#L197 I think you might be better off filing the bug over there. Let me know if my assessment is somehow incorrect. |
Agree—after I slept on this I realized that the Flank project was probably the better place to go for this. I filed this issue: Flank/flank#2228 That said, this page in the Fladle documentation might merit a small mention of Workload Identity Federation https://runningcode.github.io/fladle/authentication/ |
Yes, PRs welcome. I haven't used Workload Identity Federation so perhaps I'm not the best person to write those docs. |
When using Workload Identity Federation on GitHub Actions, there are a few compatibility issues that come up with Fladle. The token provided by the Google Auth GitHub Action doesn't include the Google Cloud Project name, which is a difference from creating a traditional long-lived service key.
This causes a problem where Fladle fails, because the Google Cloud Project name cannot be found. The workaround is to provide the project name through an environment variable
GOOGLE_CLOUD_PROJECT
which can get picked up by Flank. An example of this is here https://github.com/zcash/secant-android-wallet/blob/45e14e6a4bcb0d5070ea17dc06feba7050f65ea6/.github/workflows/pull-request.yml#L337However this reveals another minor issue, which is that an error appears in the log like this:
So I'd like to suggest a few enhancements:
GOOGLE_CLOUD_PROJECT
environment variableGOOGLE_CLOUD_PROJECT
environment variable is presentThe text was updated successfully, but these errors were encountered: