-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reproducible Builds #566
Comments
@rumboalla you're still around? |
I guess it's because of the R8 minifying. |
That could very well be. Do you exclude some classes from it? To my experience, R8 mostly works with RB (eh: R8, RB – looks to similarly spelled even) – but often breaks when something is explicitly excluded.
Could you give me a ping when the first such release is available? I'd test that again then. Thanks! |
All the CI releases are done this way https://github.com/rumboalla/apkupdater/releases?q=CI&expanded=true |
OK, then I misunderstood you. I thought you meant you were switching to that now. So the next release won't "magically fix it". Can you then please answer my question if you've set something to be excluded from R8? Oops, never mind, found it – and yes, I see a lot of If you're interested in achieving reproducible builds, we could try to figure out: you could provide me an APK where R8 was turned off, and the corresponding commit. I'd then run that through my builder and report back. |
I've checked your app if its build is reproducible (see: Reproducible bulds, special client support and more in our repo), but while I was able to successfully generate the APK using
./gradlew assembleRelease
, the differences to the one provided at your latest release were huge. Was that APK really built from the commit the tag points to? If so, did I miss some build options? And if not, which commit was it?APK Diff:
The Dex diff is really huge, almost as if it were an entirely different app, and to me indicates it's very unlikely both APKs were built from the same commit.
We'd appreciate if you could help making your build reproducible. We've prepared some hints on reproducible builds for that.
Looking forward to your reply!
The text was updated successfully, but these errors were encountered: