Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot re-enable auto correction in version 0.9.2 #133

Open
amourchaleur opened this issue Jul 28, 2022 · 4 comments
Open

Cannot re-enable auto correction in version 0.9.2 #133

amourchaleur opened this issue Jul 28, 2022 · 4 comments
Labels
bug Something isn't working Thunderbird Thunderbird-only bugs

Comments

@amourchaleur
Copy link

Bug description

After the update to the latest version 0.9.2, not able to re-enable emoji autocorrection - same issue as Unicodify – Text transformer 0.5.1.

Steps to reproduce

When I tried clicking on the checkbox, it just doesn't checked at all. Auto correction also does not turn on.

Actual behavior

No reaction to checkbox after clicking on it.

Operating system and version:
Browser and version: Thunderbird 91.11.0 (64-bit)
Add-on version: 0.5.1

Thank you!

@amourchaleur amourchaleur added bug Something isn't working Thunderbird Thunderbird-only bugs labels Jul 28, 2022
@tdulcet
Copy link
Contributor

tdulcet commented Jul 28, 2022

Thanks and thanks for helping test this feature! Anyway, my response is the same as in rugk/unicodify#77 (comment), as this code is the same for both add-ons...

@tdulcet
Copy link
Contributor

tdulcet commented Jul 29, 2022

I just published v0.9.3 on ATN which works around bug 1780977 to allow the autocorrection feature to be reenabled. This also fixes a regression to allow users to undo the :colon: shortcode autocompletions.

@rugk - This issue can now be closed.

@amourchaleur - You should automatically get the update within 24 hours or you can force it from the Add-ons manager.

@rugk
Copy link
Owner

rugk commented Jul 29, 2022

@tdulcet Again please tag these changes and so on, yeah. I mean for <1.0 it's okay, but for proper releases later we should really have a changelog and not release versions without having stuff merged into the main branch.

We e.g. have no commit which fixes this (always feel free to write "Fixes #XY" into your commit so GitHub links and closes this automatically.

@tdulcet
Copy link
Contributor

tdulcet commented Jul 30, 2022

@rugk - Yes, I agree, which is why I have been trying for over two years to get all my improvements and the changes need for Thunderbird merged into master. As you know, that has been an extremely slow process... I was really hoping it would be finished before the Thunderbird 102 ESR release so we could finally synchronize the Firefox/Thunderbird version numbers, as it was a lot of work to rebase my changes on top of master again, but of course no such luck... Anyway, I did publish a changelog on ATN.

For reference, this was fixed by tdulcet@087db04 in my fork. I do not have permission to close issues here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Thunderbird Thunderbird-only bugs
Projects
None yet
Development

No branches or pull requests

3 participants