-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Vite struggles with package due to configuration (with repro) #1757
Comments
Hello @lukebowerman |
Hello @lukebowerman |
Thank you! |
Hello @lukebowerman, Can you please check and confirm? |
Just tested it out in a staging and production environments and it appears to be working perfectly now. Thank you! |
Resubmitting this as I commented a while back on the closed ticket but haven't heard back.
Describe the bug
Managed to workaround this issue (manually marked package as ESM) but would love it the issues identified here: https://publint.dev/@rudderstack/[email protected] were addressed so this would "just work" with vite builds. :)
To Reproduce
Visit the report at: https://publint.dev/@rudderstack/[email protected]
Additional Information (please complete the following information):
I apologize for dropping the ball here. Got swamped with other things and never made it back to putting together a reproduction.
I went ahead and created a bare-bones Remix+Vite app with Rudderstack to show the issue. The repo is at https://github.com/lukebowerman/vite-remix-rudderstack-repro
To reproduce:
You should see the following output when attempting to visit the application:
The workaround is to add the package to the Vite config with
ssr.noExternal
but more ideally thepackage.json
in your upstream package would be fixed to include"type": "module"
You can see the publint's recommendations at: https://publint.dev/@rudderstack/[email protected]
Originally posted by @lukebowerman in #1623 (comment)
The text was updated successfully, but these errors were encountered: