Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Style/StringLiterals cop in RuboCop #775

Closed
tnir opened this issue Jul 27, 2022 · 1 comment · Fixed by #788
Closed

Enable Style/StringLiterals cop in RuboCop #775

tnir opened this issue Jul 27, 2022 · 1 comment · Fixed by #788
Assignees
@tnir
Labels
architecture/maintenance Daily architecture update contributor experience Contributor/Maintainer experience ruby Pull requests that update Ruby code
Milestone
Architecture over...

Comments

@tnir
Copy link
Collaborator

tnir commented Jul 27, 2022 •
edited
Loading

Quotations in Ruby files can be controlled by RuboCop.

Should we introduce haml-lint and split using double quotes and enforcing its usage from now on to a separate PR?

Originally posted by @deivid-rodriguez in #773 (review)

cf.
@tnir
Copy link
Collaborator Author

tnir commented Jul 27, 2022

cc @deivid-rodriguez

@tnir tnir mentioned this issue Jul 27, 2022
Closed
@tnir tnir added ruby Pull requests that update Ruby code architecture/maintenance Daily architecture update contributor experience Contributor/Maintainer experience labels Jul 27, 2022
@tnir tnir added this to the Architecture overhaul milestone Jul 27, 2022
@tnir tnir self-assigned this Jul 27, 2022
This was referenced Jul 27, 2022
Merged
Merged
Open
Merged
@tnir tnir closed this as completed in #788 Jul 28, 2022
@tnir tnir mentioned this issue Jul 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tnir tnir

Labels
architecture/maintenance Daily architecture update contributor experience Contributor/Maintainer experience ruby Pull requests that update Ruby code
Projects
None yet
Milestone
Architecture overhaul H2 2022
Development

Successfully merging a pull request may close this issue.

Enable Style/StringLiterals in RuboCop rubygems/bundler-site
1 participant
@tnir