You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is no set_logger method on LoggerWrapper, set_logger should be set_real_logger. Currently when initializing the LoggerWrapper with a "real" logger, it will try to set the logger via the method_missing which will silently swallow the bug.
Looks like there was an attempt to fix this in the past, but I suspect the fix highlighted other issues which were no-longer silently swallowed, but appeared to be brought about by the fix... acd4f94
Although perhaps warnings were coming from the attempt to access the instance variable by use of the instance variable, instance_variable_defined?(@real_logger) should be instance_variable_defined?(:@real_logger). Perhaps the defined? method would be more appropriate here.
The text was updated successfully, but these errors were encountered:
There is no
set_logger
method onLoggerWrapper
,set_logger
should beset_real_logger
. Currently when initializing theLoggerWrapper
with a "real" logger, it will try to set the logger via themethod_missing
which will silently swallow the bug.rubycas-client/lib/casclient.rb
Line 50 in 195a4b7
Looks like there was an attempt to fix this in the past, but I suspect the fix highlighted other issues which were no-longer silently swallowed, but appeared to be brought about by the fix...
acd4f94
Although perhaps warnings were coming from the attempt to access the instance variable by use of the instance variable,
instance_variable_defined?(@real_logger)
should beinstance_variable_defined?(:@real_logger)
. Perhaps thedefined?
method would be more appropriate here.The text was updated successfully, but these errors were encountered: