Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GitHub tokens #572

Closed
skyzyx opened this issue Feb 8, 2024 · 5 comments
Closed

Add support for GitHub tokens #572

skyzyx opened this issue Feb 8, 2024 · 5 comments

Comments

@skyzyx
Copy link

skyzyx commented Feb 8, 2024

It would be helpful to add support for a token parameter so that we can more easily avoid GitHub rate limits.

https://github.com/ruby/setup-ruby/blob/master/ruby-builder.js#L91

@eregon
Copy link
Member

eregon commented Feb 9, 2024

Are you hitting these limits? What's the limit?

@skyzyx
Copy link
Author

skyzyx commented Feb 9, 2024

60 requests per hour for unauthenticated requests. It's 5,000 per hour for authenticated requests.

We're running inside GitHub Actions on GitHub Enterprise Server, and with the way that our CI nodes poke out through the corporate network, GitHub thinks all requests are coming from the same IP.

@eregon
Copy link
Member

eregon commented Feb 12, 2024

It'd be nice if we could automatically use the token, like actions/checkout does it in https://github.com/actions/checkout/blob/b4ffde65f46336ab88eb53be808477a3936bae11/action.yml#L24
But I'm not sure if that works for all actions.

In any case we need a token input, a PR to add this is welcome.

@eregon
Copy link
Member

eregon commented May 22, 2024

What counts as requests here?
Downloading release assets?
I don't think setup-ruby does any other network interaction, except the cache stuff.

@eregon
Copy link
Member

eregon commented May 30, 2024

No reply, seems there is no need, closing

@eregon eregon closed this as not planned Won't fix, can't repro, duplicate, stale May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants