Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore seamless termination of layout shift in editor #9

Open
westonruter opened this issue Feb 27, 2023 · 1 comment
Open

Explore seamless termination of layout shift in editor #9

westonruter opened this issue Feb 27, 2023 · 1 comment

Comments

@westonruter
Copy link
Collaborator

As noted in the readme, layout shift termination only happens manually for each blog inserted:

Screen.recording.2023-02-27.13.57.01.webm

While this button is great for development purposes, a user shouldn't need to know to push such a button. Ideally this process would happen in the background whenever an embed block is added or modified. While the layout termination is happening, the Publish/Update button should be disabled.

Alternatively, there could be a pre-publish panel for eliminating layout shift, but that wouldn't work for updates.

@thelovekesh
Copy link
Member

It's the next task on my list. Will work on making it seamless.

Also, will try to use the iframe's sandbox attribute, as it's available on major browsers now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants