Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcode: redirect_to attribute not working / removes query params #159

Closed
marceldarvas opened this issue Jul 7, 2023 · 2 comments
Closed

Comments

@marceldarvas
Copy link

I've tested various formats (with or without a hostname) for redirect_to URL, but it always seems to redirect back to the URL that it was displayed on.

I found this bug to have been addressed before:
#96

I've checked my LiteSpeed Cache config + Cloudflare, but it remains an issue.

Additionally, I investigated this issue because from the Login Screen (with wp-login.php?redirect_to="") the query params are preserved and working fine.

There also seems to be a typo in the shortcode example here as there's a '/' at the end that doesn't belong there.

I'm not the only one seeming to have issues with this: #154

I've also tried using the rtcamp.google_default_redirect filter to override, but it didn't seem to work in my case.

I was wondering why do you have this code:
https://github.com/rtCamp/login-with-google/blame/0c4ee9c222ff6455b2e8c89d226e15708087401b/src/Modules/Shortcode.php#L147

@marceldarvas
Copy link
Author

I have got the redirection to work. However, I am still experiencing issues caused by the shortcode.

I've found RtCamp\GoogleLogin\Modules\Shortcode::scan_shortcode() to be an issue when running the CSS Cache regeneration process via the Oxygen Builder Admin Panel.

Argument #1 ($output) must be of type string, null given

Upon disabling this plugin, the regeneration process runs fine. (I had errors in Oxygen Templates giving failed AJAX requests).

@marceldarvas
Copy link
Author

I found the issue to be related to Oxygen Builders: Reusable Part Components. Although I believe some error-handling improvements could be made to the shortcode functionality of this plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant