Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HELP WANTED - Buggy tests on windows #107

Open
4 tasks done
Cielquan opened this issue May 13, 2022 · 0 comments
Open
4 tasks done

HELP WANTED - Buggy tests on windows #107

Cielquan opened this issue May 13, 2022 · 0 comments

Comments

@Cielquan
Copy link
Collaborator

Cielquan commented May 13, 2022

To Dos

  • I already searched with my favorite search engine "How to do X with rstcheck".

  • I already read and followed the README and didn't find an answer.

  • I have checked the issues and think that this is not a duplicate.

  • I added a very descriptive title to this issue.

Description

With the code rework in PR #100 some of the tests fail on windows only because of unknown reasons. I need someone with a windows machine to investigate the issue.

All of the following tests are currently skipped for windows.

The following tests are "false negatives", meaning they return no errors but they should:

  • tests/test_checker.py::TestCodeBlockChecker::test_check_bash_returns_error_on_bad_code_block (rstcheck-core)

  • tests/integration_tests/test_cli.py::TestInput::test_all_good_examples

  • tests/integration_tests/test_cli.py::TestWithoutConfigFile::test_error_without_config_file

  • tests/integration_tests/test_cli.py::TestWithConfigFile::test_bad_file_1_with_implicit_config_no_errors

  • tests/integration_tests/test_cli.py::TestWithConfigFile::test_bad_file_2_with_implicit_config_some_errors

  • tests/integration_tests/test_cli.py::TestCustomDirectivesAndRoles::test_custom_directive_and_role

  • tests/integration_tests/test_cli.py::TestSphinx::test_sphinx_role_erros_without_sphinx

  • tests/integration_tests/test_cli.py::TestSphinx::test_sphinx_role_exits_zero_with_sphinx

  • tests/integration_tests/test_cli.py::TestInput::test_all_bad_examples

  • tests/integration_tests/test_cli.py::TestInlineFlowControlComments::test_nested_bad_example_has_only_one_issue_pre310

  • tests/integration_tests/test_cli.py::TestInlineFlowControlComments::test_bad_example_has_only_one_issue_pre310

  • tests/integration_tests/test_cli.py::TestInlineIgnoreComments::test_bad_example_has_issues

  • tests/integration_tests/test_cli.py::TestInlineIgnoreComments.test_bad_example_has_no_issues_with_inline_ignores

The following test is a "false negative", meaning the test fails even though it should pass:

  • tests/integration_tests/test_cli.py::TestInput::test_all_good_examples_recurively

Additional Context

In version 5.0.0 the integration tests suit was skipped for windows too because of buggy behavior.

Operating System

Windows

Operating System Details

No response

Python Version

all

rstcheck Version

6.0.0a1

EDIT: Add additional tests from PR #103
EDIT2: Fix sections
EDIT3: Add more failing tests
EDIT4: Add more failing tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant