Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use another variable assignment with a combined operator for string concatenations #288

Open
elfring opened this issue Nov 27, 2021 · 0 comments

Comments

@elfring
Copy link

elfring commented Nov 27, 2021

馃憖 Some source code analysis tools can help to find opportunities for improving software components.
馃挱 I propose to increase the usage of combined operators accordingly.

diff --git a/rsnapshot-program.pl b/rsnapshot-program.pl
index 385ce11..2d1d560 100755
--- a/rsnapshot-program.pl
+++ b/rsnapshot-program.pl
@@ -566,7 +566,7 @@ sub parse_config_file {
                # if the next line begins with space or tab and also has a non-space character, then it belongs to this line as a continuation.
                while (defined($configs[$file_line_num]) && $configs[$file_line_num] =~ /^[\t ]+\S/) {
                        (my $newline = $configs[$file_line_num]) =~ s/^\s+|\s+$//g;
-                       $line = $line . "\t" . $newline;
+                       $line .= "\t" . $newline;
                        $file_line_num++;
                }
 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant