Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precompiles are not derived from DataWord #2072

Open
fedejinich opened this issue Jul 11, 2023 · 0 comments
Open

Precompiles are not derived from DataWord #2072

fedejinich opened this issue Jul 11, 2023 · 0 comments

Comments

@fedejinich
Copy link
Contributor

This should be a minor issue, but HD_WALLET_UTILS_ADDR & BLOCK_HEADER_ADDR precompiles are being derived from raw String address instead of being derived from DataWord (like all the other precompiles).

It should be an easy-to-go issue without affecting any functionality nor-consensus rule.

public static final RskAddress HD_WALLET_UTILS_ADDR = new RskAddress(HD_WALLET_UTILS_ADDR_STR);

public static final RskAddress BLOCK_HEADER_ADDR = new RskAddress(BLOCK_HEADER_ADDR_STR);

Also, I've done a quick check by doing the change and re-running the tests, and everything was ok (as expected).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant