-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transaction.encode() should be renamed encodeTxWith() #1847
Comments
hmm.. if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The method encodes the transaction, not only the signature given in the arguments v,r and s. The name encode(v,r,s) suggests that what is encoded are the arguments.
The text was updated successfully, but these errors were encountered: