Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TransactionExecutor.gasUsedInTheBlock is always zero #1648

Open
fedejinich opened this issue Nov 3, 2021 · 1 comment
Open

TransactionExecutor.gasUsedInTheBlock is always zero #1648

fedejinich opened this issue Nov 3, 2021 · 1 comment

Comments

@fedejinich
Copy link
Contributor

The current implementation of TransactionExecutor requires setting up an amount of gasUsedInTheBlock, this it's done by the TransactionExecutorFactory.

The problem here is that that this parameter it's always started in zero, and it doesn't seem to be relevant (even at the tests it's always zero). So I propose to

  • set up a default value and/or
  • get rid of this custom parameter
@fedejinich fedejinich changed the title TransactionExecutorFactory totalGasUsed is always zero TransactionExecutor.gasUsedInTheBlock is always zero Nov 3, 2021
@fedejinich
Copy link
Contributor Author

fedejinich commented Nov 3, 2021

Another proposal might be removing the TransactionExecutorFactory it doesn't add much value, there are just two kinds of TransactionExecutor instances

  1. a transaction execution instance
  2. a local execution instance (without vmTrace and with no deletedAccounts)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant