Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify Transaction construction #1583

Open
fedejinich opened this issue Jul 6, 2021 · 0 comments
Open

Unify Transaction construction #1583

fedejinich opened this issue Jul 6, 2021 · 0 comments
Labels
core ⚛️ tech debt & clean code

Comments

@fedejinich
Copy link
Contributor

As previously mentioned on this other issue, we must relay only in one Transaction constructor and use overloads for any other case. Also if a complex construction it's needed, it should be done in a static method.

We should keep object constructions as simple as they are to prevent unexpected behaviors and potential vulnerabilities.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core ⚛️ tech debt & clean code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fedejinich