Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Appropriate delegation of revert reason #1560

Open
fedejinich opened this issue Jun 14, 2021 · 0 comments
Open

Appropriate delegation of revert reason #1560

fedejinich opened this issue Jun 14, 2021 · 0 comments
Labels
core ⚛️ good first issue refactor tech debt & clean code

Comments

@fedejinich
Copy link
Contributor

Actually EthModule has the responsability to decode a revert reason, but

  • it has nothing to do with it
  • It's a stateless method which depends mostly on the program result.

Therefore, I propose to delegate properly and decode the revert reason directly at ProgramResult.

rskj/rskj-core/src/main/java/co/rsk/rpc/modules/eth/EthModule.java

Line 248 in c94ab4a

public static Optional<String> decodeRevertReason(ProgramResult res) {

@fedejinich fedejinich changed the title Appropriate delegation for revert reason Appropriate delegation of revert reason Jun 14, 2021
@fedejinich fedejinich mentioned this issue Jun 15, 2021
Draft
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core ⚛️ good first issue refactor tech debt & clean code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fedejinich