Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

to not increment when call bar(0) #264

Open
luewh opened this issue Jan 27, 2024 · 1 comment
Open

to not increment when call bar(0) #264

luewh opened this issue Jan 27, 2024 · 1 comment
Labels
improvement It does work, but there's this little thing
Milestone
3.2

Comments

@luewh
Copy link

luewh commented Jan 27, 2024

I have to check the progress each periode of time then update the bar with pregression difference, but this value could be 0, so it updated 1 while it doesn't need.
I can add a condition to check if it is 0 but it would be logical to not increment when call bar(0).
@rsalmei
Copy link
Owner

rsalmei commented Jan 28, 2024 •
edited

Yes, it makes sense. Also, it would be on par with the manual mode bar, which does accept 0. (float) as input.
I'll do it on the next release.

@rsalmei rsalmei added this to the 3.2 milestone Jan 28, 2024
@rsalmei rsalmei added the improvement It does work, but there's this little thing label Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement It does work, but there's this little thing
Projects
None yet
Milestone
3.2
Development

No branches or pull requests
2 participants
@rsalmei @luewh