Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Seeking within player doesn't correctly handle scrolling #1472

Open
1 task done
richard-misiak-az opened this issue May 9, 2024 · 1 comment
Open
1 task done
Labels
bug Something isn't working

Comments

@richard-misiak-az
Copy link

richard-misiak-az commented May 9, 2024

Preflight Checklist

  • I have searched the issue tracker for a bug report that matches the one I want to file, without success.

What package is this bug report for?

rrweb

Version

2.0.0-alpha.13

Expected Behavior

When seeking within the player for events that include page scrolling the replay should work correctly when seeking

Actual Behavior

When seeking through events that include scrolling the scrolling does not appear to be correctly reset meaning that the elements in the replay are now out of sync with the viewport position

Steps to Reproduce

  1. Go to the testcase below, it includes some interaction with fields and scrolling
  2. Let the events play
  3. using the player controls jump to ~4s
  4. jump back to ~1s
  5. resume the player

What it should look like:
image

However while seeking the scroll events aren't undone meaning the viewport is in the wrong position on the page meaning you see this instead:
image

Testcase Gist URL

https://rrwebdebug.com/play/index.html?url=https%3A%2F%2Fgist.github.com%2Frichard-misiak-az%2F7c5f1bfa491d9f7387c7bb51edbe2cd8&version=2.0.0-alpha.12&virtual-dom=on&play=on

Additional Information

No response

@richard-misiak-az richard-misiak-az added the bug Something isn't working label May 9, 2024
@richard-misiak-az richard-misiak-az changed the title [Bug]: Seeking withing player doesn't correctly handle scrolling [Bug]: Seeking within player doesn't correctly handle scrolling May 9, 2024
@richard-misiak-az
Copy link
Author

I've done some further testing with the debugger and 0.7.14 (rrweb v1.1.3) does not have this issue, but all later alpha versions do so I guess it's related to the rewrite of the replayer logic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant