Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Setting name as data.payload.name instead of data.tag #1425

Open
1 task done
Archish27 opened this issue Mar 14, 2024 · 0 comments
Open
1 task done
Labels
feature request Things want to be added

Comments

@Archish27
Copy link

Preflight Checklist

  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.

What package is this feature request for?

rrweb

Problem Description

Idea is to have two multiple custom names under same tag.

Example:
tag name as error & event name as Some error occurred in application

Why what is the idea behind this?
Currently there is no way to group event names under same tag. By doing so we can define same color to specific tag.

Proposed Solution

instead of this

const customEvent = {
          name: event.data.tag,
          background: tags[event.data.tag] || 'rgb(73, 80, 246)',
          position: `${position(start, end, event.timestamp)}%`,
        };
customEvents.push(customEvent);

to

const customEvent = {
          name: event.data.name,
          background: tags[event.data.tag] || 'rgb(73, 80, 246)',
          position: `${position(start, end, event.timestamp)}%`,
 };
customEvents.push(customEvent);

Alternatives Considered

N/A

Additional Information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Things want to be added
Projects
None yet
Development

No branches or pull requests

1 participant