APNS (HTTP/2) certificate check doesn't happen

[shekhirin]

Describe the bug
Some important validations in APNS2 are missed.

rpush/lib/rpush/client/active_model/apns/app.rb

Line 10 in 70b16a3

validate :certificate_has_matching_private_key

To Reproduce
Steps to reproduce the behavior:

1. app = Rpush::Apns::App.new
2. app.certificate = "wrong certificate"
3. app.save
4. Everything's fine!

Expected behavior

rpush/lib/rpush/client/active_model/apns/app.rb

Line 28 in 70b16a3

errors.add :certificate, 'value must contain a certificate and a private key.'

System configuration

• OS: macOS
• OS version: 10.14.4
• Ruby version: 2.2.2
• Rails version: 4.0.13
• Rpush version: 3.0.2

Additional context
Validations are being executed in self.included(base) method of Rpush::Client::ActiveModel::Apns::App module but it actually called with extend not include in Rpush::Client::ActiveModel::Apns2::App

rpush/lib/rpush/client/active_model/apns2/app.rb

Line 6 in 70b16a3

extend Rpush::Client::ActiveModel::Apns::App

[drn]

Thanks @shekhirin - sorry for the delayed response. It seems like you already have a proposed solution. Feel free to open a PR for this and I can facilitate getting the changes merged.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. If this is still an issue, please leave another comment. This issue will be closed if no further activity occurs.
Thank you for all your contributions!

[stale]

This issue has been automatically marked as stale because it has not had recent activity. If this is still an issue, please leave another comment. This issue will be closed if no further activity occurs.
Thank you for all your contributions!