Bitmap.prototype.getAlphaPixel return the wrong type

[niokasgami]

Hello,
I noticed meanwhile working on the typescript conversion I noticed that
Bitmap.prototype.getAlphaPixel is supposed to return a String although my linter show it's return an Uint8ClampedArray

wich is making the documentation wrong.

I suggest for fix this to either change the return type from the comment from String to Uint8ClampedArray or to do this :

    Bitmap.prototype.getAlphaPixel = function(x,  y) {
        var data = this._context.getImageData(x, y, 1, 1).data;
        return data[3].toString();
    };

thanks for your time!

[niokasgami]

Nevermind my version was outdated without I noticed
Closing this.

[niokasgami]

I am reopening again due that I noticed that yes this was indeed having a error

/**
 * Returns pixel color at the specified point.
 *
 * @method getPixel
 * @param {Number} x The x coordinate of the pixel in the bitmap
 * @param {Number} y The y coordinate of the pixel in the bitmap
 * @return {String} The pixel color (hex format)
 */
Bitmap.prototype.getPixel = function(x, y) {
    var data = this._context.getImageData(x, y, 1, 1).data;
    var result = '#';
    for (var i = 0; i < 3; i++) {
        result += data[i].toString(16).padZero(2);
    }
    return result;
};

/**
 * Returns alpha pixel value at the specified point.
 *
 * @method getAlphaPixel
 * @param {Number} x The x coordinate of the pixel in the bitmap
 * @param {Number} y The y coordinate of the pixel in the bitmap
 * @return {String} The alpha value
 */
Bitmap.prototype.getAlphaPixel = function(x, y) {
    var data = this._context.getImageData(x, y, 1, 1).data;
    return data[3];
};

getPixel is indeed converted but not AlphaPixel

[molingyu]

Should we add color class?

[ghost]

getAlphaPixel returns alpha value of specified pixel, so It's correct.
We agree method name doesn't have clear intention,
But for compatibility, We cannot change it.