Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nano-minibuffer implicitly depends on nano-color #80

Open
rprechelt opened this issue May 29, 2021 · 1 comment
Open

nano-minibuffer implicitly depends on nano-color #80

rprechelt opened this issue May 29, 2021 · 1 comment

Comments

@rprechelt
Copy link

The optional nano-minibuffer.el uses material-color on L54 but does not explicitly load nano-colors.el which is another optional module and therefore causes a backtrace error if your init file doesn't already require nano-colors.

For ease of use by new emacs users, I think it would be better if:

  1. A sentence is added to the description of nano-minibuffer.el in the README that nano-colors.el is also required and must be loaded first, or
  2. nano-colors.el is explicitly loaded by nano-minibuffer.el, or
  3. We replace the call to material-color with one from nano-basecolors.el.

I'll happily make an MR if you have an opinion about which of these options you'd like to see merged.

@rougier
Copy link
Owner

rougier commented May 30, 2021

Good catch, thank you. I think option 3 might be the best and the most compatible with dark/light themes. If you can make a PR that would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants