Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error "Invalid face" bookmark-menu-heading #127

Open
philipsd6 opened this issue Oct 6, 2022 · 6 comments
Open

error "Invalid face" bookmark-menu-heading #127

philipsd6 opened this issue Oct 6, 2022 · 6 comments

Comments

@philipsd6
Copy link

When executing find-file in emacs 29.0.50, if you TAB to complete a few times, the error is thrown:

error "Invalid face" bookmark-menu-heading

The bookmark-menu-heading face was removed recently:

commit 021ae515f912d941f0c41d2c6d3c8d322ac9e584
Author: Stefan Kangas <[email protected]> 
Date:   Fri Aug 19 18:24:42 2022 +0200

    * lisp/bookmark.el (bookmark-menu-heading): Delete face.

For those of us using recent versions of emacs, a quick fix is:

sed -i '/bookmark-menu-heading/d' /path/to/nano-emacs/nano-theme.el

For the long run, I guess this setting should have a version guard?

@rougier
Copy link
Owner

rougier commented Oct 10, 2022

Thanks. I think the nano-theme should handle this case but I'm not quite sure how to integrate with nano-emacs that do not require any installation.

@mandarvaze
Copy link

@philipsd6 which path do I run the sed command from ?

@philipsd6
Copy link
Author

It depends on where you install it; for me, I'm using straight, so my command is:

sed -i '/bookmark-menu-heading/d' ~/.emacs.d/straight/repos/nano-emacs/nano-theme.el

@mandarvaze
Copy link

mandarvaze commented Mar 1, 2023

Thanks @philipsd6
It worked!

@cnngimenez
Copy link

Hi!
I added a check on set-face before setting the face. This is the commit on my repository.

This check just message a warning when the face does not exists, in this case, bookmark-menu-heading. Maybe, this is not the solution, but it may be useful for future versions.

Is this useful? Should I do a Pull- Request?

Ah! Is this the same issue as Issue #135 ?

@rougier
Copy link
Owner

rougier commented Apr 3, 2023

Same issue and your fix is nice actually. If you can make a PR that would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants