Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More consistent package management and several typos #3

Open
ratyaa opened this issue Jul 1, 2022 · 1 comment
Open

More consistent package management and several typos #3

ratyaa opened this issue Jul 1, 2022 · 1 comment

Comments

@ratyaa
Copy link

ratyaa commented Jul 1, 2022

I'm currently rewriting my emacs config from scratch, and your config is the one I'm taking inspiration from, i. e. carefully reading.

In package management section I found that you can also add your own packages (and other packages those require additional configuration information for straight) to the package-list as a quoted s-exps, e. g. doing this:

(setq package-list
      '(vc-backup
	 savehist
	 '(org-imenu :type git :host github :repo "rougier/org-imenu")))

(dolist (package package-list)
  (straight-use-package package))

;; And you don't need to invoke straight-use-package manually for each of those packages like here:
;; (straight-use-package
;;  '(org-imenu :type git :host github :repo "rougier/org-imenu"))

Also found two typos, the first one is in encoding section, and maybe this one is also a mistake:

;; set-default-coding-systems duplication, from your config:
(set-default-coding-systems 'utf-8)     ; Default to utf-8 encoding
(prefer-coding-system       'utf-8)     ; Add utf-8 at the front for automatic detection.
(set-default-coding-systems 'utf-8)     ; Set default value of various coding systems

The second one is in my/date-is-yesterday function:

;; Nothing serious here, just replace 'today' in the description with 'yesterday'
(defun my/date-is-yesterday (date)
  "Check if DATE is today."
  
  (my/date-equal (my/date-dec (my/date-today) 1) date))

And one more thing, thank you for sharing your work! It's a beautiful gem and also a good research resource for emacs hackers as me, those have no time and patience for learning emacs deep enough to make this things from scratch :)

@rougier
Copy link
Owner

rougier commented Jul 11, 2022

Thanks for all the feedback. I didn't know about straight package. I thinkg I'll stick to the current form though because I find it easier to read with aligned comments.

By they way, I just fixed the my/date-relative function (in case you were using it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants