Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation typo #283

Open
gorskidev opened this issue Jul 26, 2020 · 0 comments · May be fixed by #287
Open

Documentation typo #283

gorskidev opened this issue Jul 26, 2020 · 0 comments · May be fixed by #287

Comments

@gorskidev
Copy link

Line 519, README.md
acc = Array.from(range1.byRange(range2, { excludeEnd, true, step: 2 }));

I believe the correct version should be:
acc = Array.from(range1.byRange(range2, { excludeEnd: true, step: 2 }));

I do understand that this isn't crucial, but I believe that this will be useful for future users of this great tool.
@gorskidev gorskidev reopened this Sep 14, 2020
bastienmoulia added a commit to bastienmoulia/moment-range that referenced this issue Nov 5, 2020
@bastienmoulia
Documentation typo
a28c481 
Fix rotaready#283
@bastienmoulia bastienmoulia linked a pull request Nov 5, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Documentation typo bastienmoulia/moment-range
1 participant
@gorskidev