Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename parameters to be consistent with JamesIves' action #4

Open
rossjrw opened this issue Apr 8, 2022 · 2 comments
Open

Rename parameters to be consistent with JamesIves' action #4

rossjrw opened this issue Apr 8, 2022 · 2 comments
Labels
enhancement New feature or request
Milestone
v2

Comments

@rossjrw
Copy link
Owner

rossjrw commented Apr 8, 2022

It was a silly idea to make this action so parallel to JamesIves', while also renaming parameters.

E.g. 'source-dir' should be renamed to 'folder'.

This will result in much easier integration with projects using JamesIves/github-pages-deploy-action, which is the intended use case.

I should retain the current parameters, but mark them as deprecated.
@rossjrw rossjrw added the enhancement New feature or request label Apr 8, 2022
@rossjrw
Copy link
Owner Author

rossjrw commented Apr 14, 2022

I'm going to be releasing v2 sometime after merging #6, so I may as well get this out of the way then. Best to lump all the breaking changes together.

@rossjrw rossjrw added this to the v2 milestone Apr 14, 2022
@airtonix
Copy link

can you also please expose all the variables from JamesIves/github-pages-deploy-action ...

any that you don't use directly, just pass them through to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v2
Development

No branches or pull requests
2 participants
@airtonix @rossjrw