Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--folders-to-skip Doesn't seem to work with path delimiters #71

Open
qwk000 opened this issue Sep 10, 2021 · 3 comments
Open

--folders-to-skip Doesn't seem to work with path delimiters #71

qwk000 opened this issue Sep 10, 2021 · 3 comments
Milestone

Comments

@qwk000
Copy link

qwk000 commented Sep 10, 2021

Hi. I have a subfolder that I want to exclude that has the same name as a subfolder in another tree which I do want to include. In this case, I can't just use the name in the --folders-to-skip option like this:

pygount --folders-to-skip=[...]com_arc

because both "com_arc" directories in the separate trees get excluded. When I do this:

pygount --folders-to-skip=[...]ip_project/com_arc

nothing gets excluded. I have tried a lot of different things with wildcards and using [regex]. Seems like a bug but I'm hoping there's some trick I'm missing.

Thanks,
Wes

@DarthMikke
Copy link

I also have the same problem, I can only exclude subdirectories of the directory I execute pygount from. The following command works just fine:

% pygount --folders-to-skip="[...],frontend,migrations,static" -f summary

However, this includes all subdirectories of my project, including frontend/node_modules:

% pygount --folders-to-skip="[...],frontend/node_modules,migrations,static"

@mathben
Copy link

mathben commented Feb 11, 2023

Same problem

Example, I want to exclude this file by excluding /libs/ : a/b/c/libs/js/tom.js

pygount --folders-to-skip="[...],*/libs/*" -f summary
Nothing happen

@roskakori
Copy link
Owner

That's how the current implementation works, which is not a good thing. There also is a request to support the ** for recursive folders, see #59.

Probably this would need a major rework of some not very interesting code, so it's increasingly unlikely I will look into it.

At some point I will implement #20, which is what most people including myself need. While doing that, it would be feasible to rethink the ignore logic and go for some breaking changes.

@roskakori roskakori added this to the v2.0.0 milestone Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🆕 New
Development

No branches or pull requests

4 participants