Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup validation for declared field formats #82

Open
roskakori opened this issue Jan 5, 2015 · 0 comments
Open

Cleanup validation for declared field formats #82

roskakori opened this issue Jan 5, 2015 · 0 comments
Labels

Comments

@roskakori
Copy link
Owner

Goal: parameters for fields.AbstractFieldFormat.__init__() are validated by there instead of mostly in interface.Cid.add_field_format().

The necessary changes are basically:

  1. Add optional location to fields.AbstractFieldFormat.__init__(); if None, set it to errors.create_caller_location().
  2. Move validation code for field declarations from interface.Cid.add_field_format() to fields.AbstractFieldFormat.__init__()
  3. Simplify reading of a field row by appending empty optional rows instead of repeated if item_count >= ... queries.
roskakori added a commit that referenced this issue Jul 13, 2015
Improved error message for broken field declarations in CIDs detected by the field format constructor, which now include the name of the field and the location in the CID.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant