Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should return if CONNEXTDDS_ARCH is not set after guessing #63

Open
asobhy-qnx opened this issue Aug 20, 2021 · 1 comment
Open

should return if CONNEXTDDS_ARCH is not set after guessing #63

asobhy-qnx opened this issue Aug 20, 2021 · 1 comment
Assignees

Comments

@asobhy-qnx
Copy link

should be:

        if(NOT CONNEXTDDS_ARCH)
          rti_guess_connextdds_arch()
          if(NOT CONNEXTDDS_ARCH)
            return()
          endif()
        endif()
@asorbini asorbini self-assigned this Sep 1, 2021
@asorbini
Copy link
Collaborator

asorbini commented Sep 1, 2021

Hi @asobhy-qnx,

Thank you for your suggestion! The change makes sense to me, since at the moment the build will "fall through" without a CONNEXTDDS_ARCH value, and fail more subtly at a later point.

I'll try to update the build files soon, but feel free to open a PR on the repository if you want/have the bandwidth. Community contributions are always welcome 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants