Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible XSS vulnerabilities #23

Closed
enferas opened this issue Dec 27, 2022 · 1 comment
Closed

Possible XSS vulnerabilities #23

enferas opened this issue Dec 27, 2022 · 1 comment
Assignees

Comments

@enferas
Copy link

enferas commented Dec 27, 2022

Hello,

I would like to report for possible XSS vulnerabilities.

For example,

In file InventorySystem-master\application\controllers\Stores.php in update function

$data = array(
	'name' => $this->input->post('edit_store_name'),
	'active' => $this->input->post('edit_active'),	
);

$update = $this->model_stores->update($data, $id);

In file InventorySystem-master\application\models\Model_stores.php

public function update($data, $id){
  if($data && $id) {
	  $this->db->where('id', $id);
	  $update = $this->db->update('stores', $data);
	  return ($update == true) ? true : false;
  }
}

Then In file InventorySystem-master\application\controllers\Stores.php

public function fetchStoresDataById($id) {
  if($id) {
	  $data = $this->model_stores->getStoresData($id);
	  echo json_encode($data);
  }
}

In file InventorySystem-master\application\models\Model_stores.php

public function getStoresData($id = null){
  if($id) {
	  $sql = "SELECT * FROM `stores` where id = ?";
	  $query = $this->db->query($sql, array($id));
	  return $query->row_array();
  }
  
  $sql = "SELECT * FROM `stores`";
  $query = $this->db->query($sql);
  return $query->result_array();
}
@ronknight
Copy link
Owner

Please resolve the issue and make a pull request, i'll merge it in. Thank you.

@ronknight ronknight pinned this issue Jul 22, 2024
@ronknight ronknight self-assigned this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants