Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give a empty non-null empty sourcemap warnings #1699

Open
hyf0 opened this issue Jul 23, 2024 · 2 comments
Open

Give a empty non-null empty sourcemap warnings #1699

hyf0 opened this issue Jul 23, 2024 · 2 comments
Assignees
Labels

Comments

@hyf0
Copy link
Member

hyf0 commented Jul 23, 2024

What problem does this feature solve?

.

What does the proposed API look like?

See https://github.com/rollup/rollup/blob/28546b5821efcb72c2eb05f422d986524647a0e3/src/utils/transform.ts#L73-L74 for details.

@hyf0 hyf0 changed the title Allow return null as sourcemap Allow to return null as sourcemap Jul 23, 2024
@shulaoda
Copy link
Contributor

Try it. 🙌

@underfin
Copy link
Contributor

underfin commented Jul 24, 2024

Here the null will not push into sourcemap chain, but undefined will be. The remapping result is same if has a empty sourcmap exit. Different is the undefined will be give a warning, see here.

It meaning it only need to do if here return non-null empty sourcemap. It should be added into transfrom and renderChunks hook.

@underfin underfin changed the title Allow to return null as sourcemap Give a empty non-null empty sourcemap warnings Jul 24, 2024
@github-actions github-actions bot added the stale label Sep 4, 2024
@github-actions github-actions bot added the stale label Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants